KVM: selftests: Put command line options in alphabetical order in dirty_log_perf_test
authorVipin Sharma <vipinsh@google.com>
Thu, 3 Nov 2022 19:17:14 +0000 (12:17 -0700)
committerSean Christopherson <seanjc@google.com>
Wed, 16 Nov 2022 18:03:24 +0000 (10:03 -0800)
There are 13 command line options and they are not in any order. Put
them in alphabetical order to make it easy to add new options.

No functional change intended.

Signed-off-by: Vipin Sharma <vipinsh@google.com>
Reviewed-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20221103191719.1559407-3-vipinsh@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
tools/testing/selftests/kvm/dirty_log_perf_test.c

index 56e08da3a87f47511324212368afa4bedec0bced..5bb6954b2358769c98a8db536526fe68d75f2c26 100644 (file)
@@ -406,50 +406,52 @@ int main(int argc, char *argv[])
 
        guest_modes_append_default();
 
-       while ((opt = getopt(argc, argv, "eghi:p:m:nb:f:v:os:x:")) != -1) {
+       while ((opt = getopt(argc, argv, "b:ef:ghi:m:nop:s:v:x:")) != -1) {
                switch (opt) {
+               case 'b':
+                       guest_percpu_mem_size = parse_size(optarg);
+                       break;
                case 'e':
                        /* 'e' is for evil. */
                        run_vcpus_while_disabling_dirty_logging = true;
                        break;
+               case 'f':
+                       p.wr_fract = atoi(optarg);
+                       TEST_ASSERT(p.wr_fract >= 1,
+                                   "Write fraction cannot be less than one");
+                       break;
                case 'g':
                        dirty_log_manual_caps = 0;
                        break;
+               case 'h':
+                       help(argv[0]);
+                       break;
                case 'i':
                        p.iterations = atoi(optarg);
                        break;
-               case 'p':
-                       p.phys_offset = strtoull(optarg, NULL, 0);
-                       break;
                case 'm':
                        guest_modes_cmdline(optarg);
                        break;
                case 'n':
                        perf_test_args.nested = true;
                        break;
-               case 'b':
-                       guest_percpu_mem_size = parse_size(optarg);
+               case 'o':
+                       p.partition_vcpu_memory_access = false;
                        break;
-               case 'f':
-                       p.wr_fract = atoi(optarg);
-                       TEST_ASSERT(p.wr_fract >= 1,
-                                   "Write fraction cannot be less than one");
+               case 'p':
+                       p.phys_offset = strtoull(optarg, NULL, 0);
+                       break;
+               case 's':
+                       p.backing_src = parse_backing_src_type(optarg);
                        break;
                case 'v':
                        nr_vcpus = atoi(optarg);
                        TEST_ASSERT(nr_vcpus > 0 && nr_vcpus <= max_vcpus,
                                    "Invalid number of vcpus, must be between 1 and %d", max_vcpus);
                        break;
-               case 'o':
-                       p.partition_vcpu_memory_access = false;
-                       break;
-               case 's':
-                       p.backing_src = parse_backing_src_type(optarg);
-                       break;
                case 'x':
                        p.slots = atoi(optarg);
                        break;
-               case 'h':
                default:
                        help(argv[0]);
                        break;