drm/i915/display: Fix IP version of the WAs
authorBalasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Tue, 28 Nov 2023 10:24:51 +0000 (15:54 +0530)
committerMatt Roper <matthew.d.roper@intel.com>
Wed, 29 Nov 2023 19:51:50 +0000 (11:51 -0800)
WAs 1401150847014011503030 were applied on IP versions beyond which
they are applicable. Fixed the IP version checks for these workarounds.

Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231128102451.825242-1-balasubramani.vivekanandan@intel.com
drivers/gpu/drm/i915/display/intel_display_power.c

index e390595d73416767f6c7e971b3000de3840dd2fb..f23080a4368dd068ca58e76af721f93a7166d4ca 100644 (file)
@@ -1697,14 +1697,14 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,
        if (resume)
                intel_dmc_load_program(dev_priv);
 
-       /* Wa_14011508470:tgl,dg1,rkl,adl-s,adl-p */
-       if (DISPLAY_VER(dev_priv) >= 12)
+       /* Wa_14011508470:tgl,dg1,rkl,adl-s,adl-p,dg2 */
+       if (IS_DISPLAY_IP_RANGE(dev_priv, IP_VER(12, 0), IP_VER(13, 0)))
                intel_de_rmw(dev_priv, GEN11_CHICKEN_DCPR_2, 0,
                             DCPR_CLEAR_MEMSTAT_DIS | DCPR_SEND_RESP_IMM |
                             DCPR_MASK_LPMODE | DCPR_MASK_MAXLATENCY_MEMUP_CLR);
 
        /* Wa_14011503030:xelpd */
-       if (DISPLAY_VER(dev_priv) >= 13)
+       if (DISPLAY_VER(dev_priv) == 13)
                intel_de_write(dev_priv, XELPD_DISPLAY_ERR_FATAL_MASK, ~0);
 }