btrfs: use extent_io_tree_release() to empty dirty log pages
authorFilipe Manana <fdmanana@suse.com>
Fri, 22 Sep 2023 10:39:08 +0000 (11:39 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 12 Oct 2023 14:44:15 +0000 (16:44 +0200)
When freeing a log tree, during a transaction commit, we clear its dirty
log pages io tree by calling clear_extent_bits() using a range from 0 to
(u64)-1. This will iterate the io tree's rbtree and call rb_erase() on
each node before freeing it, which will often trigger rebalance operations
on the rbtree. A better alternative it to use extent_io_tree_release(),
which will not do deletions and trigger rebalances.

So use extent_io_tree_release() instead of clear_extent_bits().

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tree-log.c

index a14ac1a964e28d4a5783814c5e0750de9b3a4827..6b98e0dbc0a4e52fe8afa9227e68d9f80b65909d 100644 (file)
@@ -3208,8 +3208,7 @@ static void free_log_tree(struct btrfs_trans_handle *trans,
                }
        }
 
-       clear_extent_bits(&log->dirty_log_pages, 0, (u64)-1,
-                         EXTENT_DIRTY | EXTENT_NEW | EXTENT_NEED_WAIT);
+       extent_io_tree_release(&log->dirty_log_pages);
        extent_io_tree_release(&log->log_csum_range);
 
        btrfs_put_root(log);