pinctrl: ocelot: Remove redundant error printing in ocelot_pinctrl_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 09:09:36 +0000 (17:09 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 19 May 2021 23:33:53 +0000 (01:33 +0200)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210511090936.4452-1-thunder.leizhen@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-ocelot.c

index 2fd18e356d0c6f2655765dc0a80ba87fd14fd038..e470c16718dea20a4b64fe48a07c22e193f66447 100644 (file)
@@ -1362,10 +1362,8 @@ static int ocelot_pinctrl_probe(struct platform_device *pdev)
 
        base = devm_ioremap_resource(dev,
                        platform_get_resource(pdev, IORESOURCE_MEM, 0));
-       if (IS_ERR(base)) {
-               dev_err(dev, "Failed to ioremap registers\n");
+       if (IS_ERR(base))
                return PTR_ERR(base);
-       }
 
        info->stride = 1 + (info->desc->npins - 1) / 32;