scsi: fas216: Introduce the function fas216_queue_command_internal()
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:46:13 +0000 (13:46 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:44 +0000 (21:31 -0400)
This patch does not change any functionality but prepares for removal of
the second argument of the fas216_queue_command_lck() function.

Link: https://lore.kernel.org/r/20211007204618.2196847-13-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/arm/fas216.c

index 91c03bde310b6e7a96cb2343e369214cd63e7da7..a8befd2eec528b3cb5bda448729bb0aa61ec0458 100644 (file)
@@ -2184,7 +2184,7 @@ no_command:
 }
 
 /**
- * fas216_queue_command - queue a command for adapter to process.
+ * fas216_queue_command_internal - queue a command for the adapter to process
  * @SCpnt: Command to queue
  * @done: done function to call once command is complete
  *
@@ -2192,8 +2192,8 @@ no_command:
  * Returns: 0 on success, else error.
  * Notes: io_request_lock is held, interrupts are disabled.
  */
-static int fas216_queue_command_lck(struct scsi_cmnd *SCpnt,
-                        void (*done)(struct scsi_cmnd *))
+static int fas216_queue_command_internal(struct scsi_cmnd *SCpnt,
+                                        void (*done)(struct scsi_cmnd *))
 {
        FAS216_Info *info = (FAS216_Info *)SCpnt->device->host->hostdata;
        int result;
@@ -2233,6 +2233,12 @@ static int fas216_queue_command_lck(struct scsi_cmnd *SCpnt,
        return result;
 }
 
+static int fas216_queue_command_lck(struct scsi_cmnd *SCpnt,
+                                   void (*done)(struct scsi_cmnd *))
+{
+       return fas216_queue_command_internal(SCpnt, done);
+}
+
 DEF_SCSI_QCMD(fas216_queue_command)
 
 /**
@@ -2272,7 +2278,7 @@ static int fas216_noqueue_command_lck(struct scsi_cmnd *SCpnt,
        BUG_ON(info->scsi.irq);
 
        info->internal_done = 0;
-       fas216_queue_command_lck(SCpnt, fas216_internal_done);
+       fas216_queue_command_internal(SCpnt, fas216_internal_done);
 
        /*
         * This wastes time, since we can't return until the command is