soc: qcom: ocmem: Fix missing put_device() call in of_get_ocmem
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 7 Jan 2022 07:31:26 +0000 (07:31 +0000)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 31 Jan 2022 22:09:50 +0000 (16:09 -0600)
The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.

Fixes: 01f937ffc468 ("soc: qcom: ocmem: don't return NULL in of_get_ocmem")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220107073126.2335-1-linmq006@gmail.com
drivers/soc/qcom/ocmem.c

index d2dacbbaafbd183ffcbb56cd8bedc5b34af8ba2f..97fd24c178f8d330272c601dd3fd5268b167182a 100644 (file)
@@ -206,6 +206,7 @@ struct ocmem *of_get_ocmem(struct device *dev)
        ocmem = platform_get_drvdata(pdev);
        if (!ocmem) {
                dev_err(dev, "Cannot get ocmem\n");
+               put_device(&pdev->dev);
                return ERR_PTR(-ENODEV);
        }
        return ocmem;