arm64: dts: exynos7885: add specific compatibles to several blocks
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 8 Nov 2023 10:43:41 +0000 (11:43 +0100)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 15 Nov 2023 11:50:40 +0000 (12:50 +0100)
Exynos7885 reuses several devices from older designs, thus historically
we kept the old (block's) compatible only.  This works fine and there is
no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to Exynos7885 in front of all old-SoC-like
compatibles.  This will also help reviews of new code using existing
DTS as template.  No functional impact on Linux drivers behavior.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Link: https://lore.kernel.org/r/20231108104343.24192-16-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
arch/arm64/boot/dts/exynos/exynos7885.dtsi

index d69fc2392bd0e37842109865f226925d7ac4d602..008228fb319a90e5b9561ac1a04fab3d7a95c536 100644 (file)
                ranges = <0x0 0x0 0x0 0x20000000>;
 
                chipid@10000000 {
-                       compatible = "samsung,exynos850-chipid";
+                       compatible = "samsung,exynos7885-chipid",
+                                    "samsung,exynos850-chipid";
                        reg = <0x10000000 0x24>;
                };
 
                        reg = <0x11cb0000 0x1000>;
 
                        wakeup-interrupt-controller {
-                               compatible = "samsung,exynos7-wakeup-eint";
+                               compatible = "samsung,exynos7885-wakeup-eint",
+                                            "samsung,exynos7-wakeup-eint";
                                interrupt-parent = <&gic>;
                                interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>;
                        };
                };
 
                pmu_system_controller: system-controller@11c80000 {
-                       compatible = "samsung,exynos7-pmu", "syscon";
+                       compatible = "samsung,exynos7885-pmu",
+                                    "samsung,exynos7-pmu", "syscon";
                        reg = <0x11c80000 0x10000>;
                };
 
                mmc_0: mmc@13500000 {
-                       compatible = "samsung,exynos7-dw-mshc-smu";
+                       compatible = "samsung,exynos7885-dw-mshc-smu",
+                                    "samsung,exynos7-dw-mshc-smu";
                        reg = <0x13500000 0x2000>;
                        interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                serial_0: serial@13800000 {
-                       compatible = "samsung,exynos5433-uart";
+                       compatible = "samsung,exynos7885-uart",
+                                    "samsung,exynos5433-uart";
                        reg = <0x13800000 0x100>;
                        interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
                        pinctrl-names = "default";
                };
 
                serial_1: serial@13810000 {
-                       compatible = "samsung,exynos5433-uart";
+                       compatible = "samsung,exynos7885-uart",
+                                    "samsung,exynos5433-uart";
                        reg = <0x13810000 0x100>;
                        interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
                        pinctrl-names = "default";
                };
 
                serial_2: serial@13820000 {
-                       compatible = "samsung,exynos5433-uart";
+                       compatible = "samsung,exynos7885-uart",
+                                    "samsung,exynos5433-uart";
                        reg = <0x13820000 0x100>;
                        interrupts = <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>;
                        pinctrl-names = "default";
                };
 
                i2c_0: i2c@13830000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x13830000 0x100>;
                        interrupts = <GIC_SPI 248 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_1: i2c@13840000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x13840000 0x100>;
                        interrupts = <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_2: i2c@13850000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x13850000 0x100>;
                        interrupts = <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_3: i2c@13860000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x13860000 0x100>;
                        interrupts = <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_4: i2c@13870000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x13870000 0x100>;
                        interrupts = <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_5: i2c@13880000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x13880000 0x100>;
                        interrupts = <GIC_SPI 253 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_6: i2c@13890000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x13890000 0x100>;
                        interrupts = <GIC_SPI 254 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                i2c_7: i2c@11cd0000 {
-                       compatible = "samsung,s3c2440-i2c";
+                       compatible = "samsung,exynos7885-i2c",
+                                    "samsung,s3c2440-i2c";
                        reg = <0x11cd0000 0x100>;
                        interrupts = <GIC_SPI 255 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;