net: ethernet: sun: Remove redundant code

Since the starting value in the for loop is greater than or equal to 1,
the restriction is CAS_FLAG_REG_PLUS is in the file cassini.h is
defined as 0x1 by macro, and the for loop and if condition is not
satisfied, so the code here is redundant.

Clean up the following smatch warning:

drivers/net/ethernet/sun/cassini.c:3513 cas_start_dma() warn: we never
enter this loop.

drivers/net/ethernet/sun/cassini.c:1239 cas_init_rx_dma() warn: we never
enter this loop.

drivers/net/ethernet/sun/cassini.c:1247 cas_init_rx_dma() warn: we never
enter this loop.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
index 947a76a788c7eea2492d04a29f5c0cdaaf2e00e3..153edc5eadad70b5a018f1416bf98533e1a9b507 100644 (file)
--- a/drivers/net/ethernet/sun/cassini.c
+++ b/drivers/net/ethernet/sun/cassini.c
@@ -1235,19 +1235,6 @@ static void cas_init_rx_dma(struct cas *cp)
         */
        readl(cp->regs + REG_INTR_STATUS_ALIAS);
        writel(INTR_RX_DONE | INTR_RX_BUF_UNAVAIL, cp->regs + REG_ALIAS_CLEAR);
-       if (cp->cas_flags & CAS_FLAG_REG_PLUS) {
-               for (i = 1; i < N_RX_COMP_RINGS; i++)
-                       readl(cp->regs + REG_PLUS_INTRN_STATUS_ALIAS(i));
-
-               /* 2 is different from 3 and 4 */
-               if (N_RX_COMP_RINGS > 1)
-                       writel(INTR_RX_DONE_ALT | INTR_RX_BUF_UNAVAIL_1,
-                              cp->regs + REG_PLUS_ALIASN_CLEAR(1));
-
-               for (i = 2; i < N_RX_COMP_RINGS; i++)
-                       writel(INTR_RX_DONE_ALT,
-                              cp->regs + REG_PLUS_ALIASN_CLEAR(i));
-       }
 
        /* set up pause thresholds */
        val  = CAS_BASE(RX_PAUSE_THRESH_OFF,
@@ -3509,9 +3496,6 @@ enable_rx_done:
                if (N_RX_DESC_RINGS > 1)
                        writel(RX_DESC_RINGN_SIZE(1) - 4,
                               cp->regs + REG_PLUS_RX_KICK1);
-
-               for (i = 1; i < N_RX_COMP_RINGS; i++)
-                       writel(0, cp->regs + REG_PLUS_RX_COMPN_TAIL(i));
        }
 }