selftests: forwarding: lib: quote the sysctl values

[ Upstream commit 3a082086aa200852545cf15159213582c0c80eba ]

When set/restore sysctl value, we should quote the value as some keys
may have multi values, e.g. net.ipv4.ping_group_range

Fixes: f5ae57784ba8 ("selftests: forwarding: lib: Add sysctl_set(), sysctl_restore()")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/r/20230208032110.879205-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
index c9507df9c05bc6e4c18faf9b3bf520f27b45a13f..b7d946cf14eb500b72732c0657bc6aabd8ea0904 100644 (file)
--- a/tools/testing/selftests/net/forwarding/lib.sh
+++ b/tools/testing/selftests/net/forwarding/lib.sh
@@ -817,14 +817,14 @@ sysctl_set()
        local value=$1; shift
 
        SYSCTL_ORIG[$key]=$(sysctl -n $key)
-       sysctl -qw $key=$value
+       sysctl -qw $key="$value"
 }
 
 sysctl_restore()
 {
        local key=$1; shift
 
-       sysctl -qw $key=${SYSCTL_ORIG["$key"]}
+       sysctl -qw $key="${SYSCTL_ORIG[$key]}"
 }
 
 forwarding_enable()