regulator: da9063: Annotate struct da9063_regulators with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:52:07 +0000 (10:52 -0700)
committerMark Brown <broonie@kernel.org>
Tue, 10 Oct 2023 21:10:10 +0000 (22:10 +0100)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct da9063_regulators.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Support Opensource <support.opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922175207.work.576-kees@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9063-regulator.c

index a0621665a6d22dfe39e5f37eef25e525e23f6ecc..82bf321ae06f0c3508f25e8dbf89e1c9fa6035de 100644 (file)
@@ -158,7 +158,7 @@ struct da9063_regulator {
 struct da9063_regulators {
        unsigned int                            n_regulators;
        /* Array size to be defined during init. Keep at end. */
-       struct da9063_regulator                 regulator[];
+       struct da9063_regulator                 regulator[] __counted_by(n_regulators);
 };
 
 /* BUCK modes for DA9063 */