mt76: mt7921s: fix a possible memory leak in mt7921_load_patch

Always release fw data at the end of mt7921_load_patch routine.

Fixes: 78b217580c509 ("mt76: mt7921s: fix bus hang with wrong privilege")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
index 509595c4157cec86427bcfbcf9229d53e52d4610..33a836825cca6c84ecdc7c73232170af7e64e066 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
@@ -541,12 +541,8 @@ static int mt7921_load_patch(struct mt7921_dev *dev)
        if (mt76_is_sdio(&dev->mt76)) {
                /* activate again */
                ret = __mt7921_mcu_fw_pmctrl(dev);
-               if (ret)
-                       return ret;
-
-               ret = __mt7921_mcu_drv_pmctrl(dev);
-               if (ret)
-                       return ret;
+               if (!ret)
+                       ret = __mt7921_mcu_drv_pmctrl(dev);
        }
 
 out: