clk: qcom: dispcc-sm6350: fix DisplayPort clocks
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Wed, 24 Apr 2024 01:39:30 +0000 (04:39 +0300)
committerBjorn Andersson <andersson@kernel.org>
Sat, 27 Apr 2024 18:14:56 +0000 (13:14 -0500)
On SM6350 DisplayPort link clocks use frequency tables inherited from
the vendor kernel, it is not applicable in the upstream kernel. Drop
frequency tables and use clk_byte2_ops for those clocks.

This fixes frequency selection in the OPP core (which otherwise attempts
to use invalid 810 KHz as DP link rate), also fixing the following
message:
msm-dp-display ae90000.displayport-controller: _opp_config_clk_single: failed to set clock rate: -22

Fixes: 837519775f1d ("clk: qcom: Add display clock controller driver for SM6350")
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Tested-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240424-dispcc-dp-clocks-v2-2-b44038f3fa96@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/dispcc-sm6350.c

index 839435362010eeed6eca5aba2ba8899f69ffc6de..e4b7464c4d0e9760cd2ee4e7627f5bd62f1e1981 100644 (file)
@@ -221,26 +221,17 @@ static struct clk_rcg2 disp_cc_mdss_dp_crypto_clk_src = {
        },
 };
 
-static const struct freq_tbl ftbl_disp_cc_mdss_dp_link_clk_src[] = {
-       F(162000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
-       F(270000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
-       F(540000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
-       F(810000, P_DP_PHY_PLL_LINK_CLK, 1, 0, 0),
-       { }
-};
-
 static struct clk_rcg2 disp_cc_mdss_dp_link_clk_src = {
        .cmd_rcgr = 0x10f8,
        .mnd_width = 0,
        .hid_width = 5,
        .parent_map = disp_cc_parent_map_0,
-       .freq_tbl = ftbl_disp_cc_mdss_dp_link_clk_src,
        .clkr.hw.init = &(struct clk_init_data){
                .name = "disp_cc_mdss_dp_link_clk_src",
                .parent_data = disp_cc_parent_data_0,
                .num_parents = ARRAY_SIZE(disp_cc_parent_data_0),
                .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
-               .ops = &clk_rcg2_ops,
+               .ops = &clk_byte2_ops,
        },
 };