xfs: remove the unnecessary daddr paramter to _init_block
authorDarrick J. Wong <djwong@kernel.org>
Thu, 22 Feb 2024 20:35:19 +0000 (12:35 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 22 Feb 2024 20:35:19 +0000 (12:35 -0800)
Now that all of the callers pass XFS_BUF_DADDR_NULL as the daddr
parameter, we can elide that too.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/libxfs/xfs_bmap_btree.c
fs/xfs/libxfs/xfs_btree.c
fs/xfs/libxfs/xfs_btree.h
fs/xfs/libxfs/xfs_btree_staging.c

index ddaf40e0f3092a49895094ec3b7188e7cf11a815..fa116c2d13aeff221fb5d88574f516b49c07e9b8 100644 (file)
@@ -38,8 +38,8 @@ xfs_bmbt_init_block(
                xfs_btree_init_buf(ip->i_mount, bp, &xfs_bmbt_ops, level,
                                numrecs, ip->i_ino);
        else
-               xfs_btree_init_block(ip->i_mount, buf, &xfs_bmbt_ops,
-                               XFS_BUF_DADDR_NULL, level, numrecs, ip->i_ino);
+               xfs_btree_init_block(ip->i_mount, buf, &xfs_bmbt_ops, level,
+                               numrecs, ip->i_ino);
 }
 
 /*
index f1db5118dbaa77c62de456f88c08fe66661d65ef..b5b9b021c67ab8da8a6670e76268f0d28aec9058 100644 (file)
@@ -1153,8 +1153,8 @@ xfs_btree_set_sibling(
        }
 }
 
-void
-xfs_btree_init_block(
+static void
+__xfs_btree_init_block(
        struct xfs_mount        *mp,
        struct xfs_btree_block  *buf,
        const struct xfs_btree_ops *ops,
@@ -1195,6 +1195,19 @@ xfs_btree_init_block(
        }
 }
 
+void
+xfs_btree_init_block(
+       struct xfs_mount        *mp,
+       struct xfs_btree_block  *block,
+       const struct xfs_btree_ops *ops,
+       __u16                   level,
+       __u16                   numrecs,
+       __u64                   owner)
+{
+       __xfs_btree_init_block(mp, block, ops, XFS_BUF_DADDR_NULL, level,
+                       numrecs, owner);
+}
+
 void
 xfs_btree_init_buf(
        struct xfs_mount                *mp,
@@ -1204,7 +1217,7 @@ xfs_btree_init_buf(
        __u16                           numrecs,
        __u64                           owner)
 {
-       xfs_btree_init_block(mp, XFS_BUF_TO_BLOCK(bp), ops,
+       __xfs_btree_init_block(mp, XFS_BUF_TO_BLOCK(bp), ops,
                        xfs_buf_daddr(bp), level, numrecs, owner);
 }
 
index 56901d2591ed73b2ba8b3a05400ed3ceea092dfa..80be40ca89547c363bc8362970dc0a155b956b55 100644 (file)
@@ -440,7 +440,7 @@ void xfs_btree_init_buf(struct xfs_mount *mp, struct xfs_buf *bp,
                __u64 owner);
 void xfs_btree_init_block(struct xfs_mount *mp,
                struct xfs_btree_block *buf, const struct xfs_btree_ops *ops,
-               xfs_daddr_t blkno, __u16 level, __u16 numrecs, __u64 owner);
+               __u16 level, __u16 numrecs, __u64 owner);
 
 /*
  * Common btree core entry points.
index b590f4580a6d0fa598526c2f31b0537bb08f08d4..e31e4bd21718db51629c4725df5581db106f10e8 100644 (file)
@@ -410,9 +410,8 @@ xfs_btree_bload_prep_block(
                ifp->if_broot_bytes = (int)new_size;
 
                /* Initialize it and send it out. */
-               xfs_btree_init_block(cur->bc_mp, ifp->if_broot,
-                               cur->bc_ops, XFS_BUF_DADDR_NULL, level,
-                               nr_this_block, cur->bc_ino.ip->i_ino);
+               xfs_btree_init_block(cur->bc_mp, ifp->if_broot, cur->bc_ops,
+                               level, nr_this_block, cur->bc_ino.ip->i_ino);
 
                *bpp = NULL;
                *blockp = ifp->if_broot;