mm/slab: break up RCU readers on SLAB_TYPESAFE_BY_RCU example code
authorSeongJae Park <sj@kernel.org>
Mon, 17 Apr 2023 19:04:50 +0000 (19:04 +0000)
committerVlastimil Babka <vbabka@suse.cz>
Thu, 8 Jun 2023 07:13:36 +0000 (09:13 +0200)
The SLAB_TYPESAFE_BY_RCU example code snippet uses a single RCU
read-side critical section for retries.
'Documentation/RCU/rculist_nulls.rst' has similar example code snippet,
and commit da82af04352b ("doc: Update and wordsmith rculist_nulls.rst")
broke it up.  Apply the change to SLAB_TYPESAFE_BY_RCU example code
snippet, too.

Signed-off-by: SeongJae Park <sj@kernel.org>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
include/linux/slab.h

index 5eeedbfffcd29d3ded032b2b2ea46eb1cab14a36..c6bc05765bdb271ffecfdf641df1a6411e39efcb 100644 (file)
  * stays valid, the trick to using this is relying on an independent
  * object validation pass. Something like:
  *
+ * begin:
  *  rcu_read_lock();
- * again:
  *  obj = lockless_lookup(key);
  *  if (obj) {
  *    if (!try_get_ref(obj)) // might fail for free objects
- *      goto again;
+ *      rcu_read_unlock();
+ *      goto begin;
  *
  *    if (obj->key != key) { // not the object we expected
  *      put_ref(obj);
- *      goto again;
+ *      rcu_read_unlock();
+ *      goto begin;
  *    }
  *  }
  *  rcu_read_unlock();