nvme: fix error-handling for io_uring nvme-passthrough
authorAnuj Gupta <anuj20.g@samsung.com>
Wed, 18 Oct 2023 19:24:30 +0000 (00:54 +0530)
committerKeith Busch <kbusch@kernel.org>
Mon, 6 Nov 2023 16:09:31 +0000 (08:09 -0800)
Driver may return an error before submitting the command to the device.
Ensure that such error is propagated up.

Fixes: 456cba386e94 ("nvme: wire-up uring-cmd support for io-passthru on char-device.")
Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/ioctl.c

index 747c879e8982b803525238afd1572fc90197fd6d..529b9954d2b8c0429e6bd7316791fef884121a29 100644 (file)
@@ -510,10 +510,13 @@ static enum rq_end_io_ret nvme_uring_cmd_end_io(struct request *req,
        struct nvme_uring_cmd_pdu *pdu = nvme_uring_cmd_pdu(ioucmd);
 
        req->bio = pdu->bio;
-       if (nvme_req(req)->flags & NVME_REQ_CANCELLED)
+       if (nvme_req(req)->flags & NVME_REQ_CANCELLED) {
                pdu->nvme_status = -EINTR;
-       else
+       } else {
                pdu->nvme_status = nvme_req(req)->status;
+               if (!pdu->nvme_status)
+                       pdu->nvme_status = blk_status_to_errno(err);
+       }
        pdu->u.result = le64_to_cpu(nvme_req(req)->result.u64);
 
        /*