ASoC: mediatek: mt8188-mt6359: clean up a return in codec_init
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 8 Jun 2023 08:47:24 +0000 (10:47 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 8 Jun 2023 10:36:18 +0000 (11:36 +0100)
This code triggers a Smatch static checker warning and does sort of
look like an error path.

sound/soc/mediatek/mt8188/mt8188-mt6359.c:597 mt8188_max98390_codec_init() warn: missing error code? 'ret'

However, returning 0 is intentional.  Make that explicit.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Link: https://lore.kernel.org/r/20230608084727.74403-3-angelogioacchino.delregno@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8188/mt8188-mt6359.c

index 643a7a12a96bd10fce587807f0b7077ce9981af9..b2735496d140d359f91cc52305d70e6b34b9ae0f 100644 (file)
@@ -594,7 +594,7 @@ static int mt8188_max98390_codec_init(struct snd_soc_pcm_runtime *rtd)
        }
 
        if (rtd->dai_link->num_codecs <= 2)
-               return ret;
+               return 0;
 
        /* add widgets/controls/dapm for rear speakers */
        ret = snd_soc_dapm_new_controls(&card->dapm, mt8188_rear_spk_widgets,