drm: adv7511: Add max_mode_clock_khz variable to struct adv7511_chip_info
authorBiju Das <biju.das.jz@bp.renesas.com>
Wed, 30 Aug 2023 14:23:52 +0000 (15:23 +0100)
committerRobert Foss <rfoss@kernel.org>
Mon, 16 Oct 2023 09:08:22 +0000 (11:08 +0200)
The ADV7533 supports a maximum pixel clock of 80MHz whereas it is 148.5MHz
for ADV7535. Add max_mode_clock_khz variable to struct adv7511_chip_info to
handle this difference.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Adam Ford <aford173@gmail.com>
Tested-by: Adam Ford <aford173@gmail.com> #imx8mm-beacon
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230830142358.275459-3-biju.das.jz@bp.renesas.com
drivers/gpu/drm/bridge/adv7511/adv7511.h
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
drivers/gpu/drm/bridge/adv7511/adv7533.c

index 59e8ef10d72ed34ff777735c5a30272960cd6e29..b9c6c1e8a353b3d0b81bdd386b9f6d54161f2170 100644 (file)
@@ -335,6 +335,7 @@ enum adv7511_type {
 
 struct adv7511_chip_info {
        enum adv7511_type type;
+       unsigned int max_mode_clock_khz;
 };
 
 struct adv7511 {
index a8508e86b39114c4b0ffd2695c5c2b1c30e73e49..4ee90a7542026c5c0910cedb9bd0a60f02756971 100644 (file)
@@ -1369,10 +1369,12 @@ static const struct adv7511_chip_info adv7511_chip_info = {
 
 static const struct adv7511_chip_info adv7533_chip_info = {
        .type = ADV7533,
+       .max_mode_clock_khz = 80000,
 };
 
 static const struct adv7511_chip_info adv7535_chip_info = {
        .type = ADV7535,
+       .max_mode_clock_khz = 148500,
 };
 
 static const struct i2c_device_id adv7511_i2c_ids[] = {
index c452c4dc1c3f4b43440e6020cd16f634ab0a89e7..1d113489754c2efcf985f865d61e458ad264b88e 100644 (file)
@@ -108,7 +108,7 @@ enum drm_mode_status adv7533_mode_valid(struct adv7511 *adv,
        u8 bpp = mipi_dsi_pixel_format_to_bpp(dsi->format);
 
        /* Check max clock for either 7533 or 7535 */
-       if (mode->clock > (adv->info->type == ADV7533 ? 80000 : 148500))
+       if (mode->clock > adv->info->max_mode_clock_khz)
                return MODE_CLOCK_HIGH;
 
        /* Check max clock for each lane */