staging: vt6655: Type encoding info dropped from array name "abyBBVGA"
authorPavan Bobba <opensource206@gmail.com>
Sun, 8 Oct 2023 19:01:48 +0000 (00:31 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 15 Oct 2023 16:21:05 +0000 (18:21 +0200)
array name "abyBBVGA" updated like below:

a.type encoding info dropped from name
b.camelcase name replaced by snakecase

Issue found by checkpatch

Signed-off-by: Pavan Bobba <opensource206@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/13a233dff4d6daf728f75ab18b38ec9d0703764b.1696791459.git.opensource206@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/baseband.c
drivers/staging/vt6655/channel.c
drivers/staging/vt6655/device.h
drivers/staging/vt6655/device_main.c

index 0ae2ab3987c6f5cc27efe5f282756d48d13fce2f..a19a75f5d7613c528d5c84328cb4fb1ac02bc3c7 100644 (file)
@@ -2016,10 +2016,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                        iowrite32(0x23, iobase + MAC_REG_ITRTMSET);
                        vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0));
                }
-               priv->abyBBVGA[0] = 0x18;
-               priv->abyBBVGA[1] = 0x0A;
-               priv->abyBBVGA[2] = 0x0;
-               priv->abyBBVGA[3] = 0x0;
+               priv->bbvga[0] = 0x18;
+               priv->bbvga[1] = 0x0A;
+               priv->bbvga[2] = 0x0;
+               priv->bbvga[3] = 0x0;
                priv->dbm_threshold[0] = -70;
                priv->dbm_threshold[1] = -50;
                priv->dbm_threshold[2] = 0;
@@ -2034,10 +2034,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                        result &= bb_write_embedded(priv,
                                vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]);
 
-               priv->abyBBVGA[0] = 0x1C;
-               priv->abyBBVGA[1] = 0x10;
-               priv->abyBBVGA[2] = 0x0;
-               priv->abyBBVGA[3] = 0x0;
+               priv->bbvga[0] = 0x1C;
+               priv->bbvga[1] = 0x10;
+               priv->bbvga[2] = 0x0;
+               priv->bbvga[3] = 0x0;
                priv->dbm_threshold[0] = -70;
                priv->dbm_threshold[1] = -48;
                priv->dbm_threshold[2] = 0;
@@ -2056,10 +2056,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                iowrite8(0x23, iobase + MAC_REG_ITRTMSET);
                vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0));
 
-               priv->abyBBVGA[0] = 0x14;
-               priv->abyBBVGA[1] = 0x0A;
-               priv->abyBBVGA[2] = 0x0;
-               priv->abyBBVGA[3] = 0x0;
+               priv->bbvga[0] = 0x14;
+               priv->bbvga[1] = 0x0A;
+               priv->bbvga[2] = 0x0;
+               priv->bbvga[3] = 0x0;
                priv->dbm_threshold[0] = -60;
                priv->dbm_threshold[1] = -50;
                priv->dbm_threshold[2] = 0;
@@ -2074,10 +2074,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
                        result &= bb_write_embedded(priv,
                                vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]);
 
-               priv->abyBBVGA[0] = 0x1C;
-               priv->abyBBVGA[1] = 0x10;
-               priv->abyBBVGA[2] = 0x0;
-               priv->abyBBVGA[3] = 0x0;
+               priv->bbvga[0] = 0x1C;
+               priv->bbvga[1] = 0x10;
+               priv->bbvga[2] = 0x0;
+               priv->bbvga[3] = 0x0;
                priv->dbm_threshold[0] = -70;
                priv->dbm_threshold[1] = -48;
                priv->dbm_threshold[2] = 0;
@@ -2088,7 +2088,7 @@ bool bb_vt3253_init(struct vnt_private *priv)
        } else {
                /* No VGA Table now */
                priv->bUpdateBBVGA = false;
-               priv->abyBBVGA[0] = 0x1C;
+               priv->bbvga[0] = 0x1C;
        }
 
        if (by_local_id > REV_ID_VT3253_A1) {
@@ -2126,7 +2126,7 @@ bb_set_short_slot_time(struct vnt_private *priv)
 
        /* patch for 3253B0 Baseband with Cardbus module */
        bb_read_embedded(priv, 0xE7, &by_bb_vga);
-       if (by_bb_vga == priv->abyBBVGA[0])
+       if (by_bb_vga == priv->bbvga[0])
                by_bb_rx_conf |= 0x20; /* 0010 0000 */
 
        bb_write_embedded(priv, 0x0A, by_bb_rx_conf); /* CR10 */
@@ -2140,7 +2140,7 @@ void bb_set_vga_gain_offset(struct vnt_private *priv, unsigned char by_data)
 
        bb_read_embedded(priv, 0x0A, &by_bb_rx_conf); /* CR10 */
        /* patch for 3253B0 Baseband with Cardbus module */
-       if (by_data == priv->abyBBVGA[0])
+       if (by_data == priv->bbvga[0])
                by_bb_rx_conf |= 0x20; /* 0010 0000 */
        else if (priv->short_slot_time)
                by_bb_rx_conf &= 0xDF; /* 1101 1111 */
index e90e0b43505da53e733165c7b4c1dc3fb8febb70..e20701815db989e4e50c5e0afee44f50a01bca7e 100644 (file)
@@ -87,8 +87,8 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
 
        /* Set VGA to max sensitivity */
        if (priv->bUpdateBBVGA &&
-           priv->byBBVGACurrent != priv->abyBBVGA[0]) {
-               priv->byBBVGACurrent = priv->abyBBVGA[0];
+           priv->byBBVGACurrent != priv->bbvga[0]) {
+               priv->byBBVGACurrent = priv->bbvga[0];
 
                bb_set_vga_gain_offset(priv, priv->byBBVGACurrent);
        }
index 8c90539cc3d71df2b6a0f59f6e529579a1b86617..b662c74a2dc7cc424c248b662438c13a9a8cdfaa 100644 (file)
@@ -250,7 +250,7 @@ struct vnt_private {
        unsigned int    uBBVGADiffCount;
        unsigned char byBBVGANew;
        unsigned char byBBVGACurrent;
-       unsigned char abyBBVGA[BB_VGA_LEVEL];
+       unsigned char bbvga[BB_VGA_LEVEL];
        long                    dbm_threshold[BB_VGA_LEVEL];
 
        unsigned char byBBPreEDRSSI;
index f76f482f4c06d32683a9a0631f01ea6494afc204..385848df884820b1596108887ea9aed13be7bd0b 100644 (file)
@@ -424,9 +424,9 @@ static void device_init_registers(struct vnt_private *priv)
        bb_vt3253_init(priv);
 
        if (priv->bUpdateBBVGA) {
-               priv->byBBVGACurrent = priv->abyBBVGA[0];
+               priv->byBBVGACurrent = priv->bbvga[0];
                priv->byBBVGANew = priv->byBBVGACurrent;
-               bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]);
+               bb_set_vga_gain_offset(priv, priv->bbvga[0]);
        }
 
        bb_set_rx_antenna_mode(priv, priv->byRxAntennaMode);
@@ -1053,7 +1053,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
 
        for (i = 0; i < BB_VGA_LEVEL; i++) {
                if (dbm < priv->dbm_threshold[i]) {
-                       priv->byBBVGANew = priv->abyBBVGA[i];
+                       priv->byBBVGANew = priv->bbvga[i];
                        break;
                }
        }
@@ -1510,7 +1510,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
                        priv->short_slot_time = false;
 
                CARDbSetPhyParameter(priv, priv->byBBType);
-               bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]);
+               bb_set_vga_gain_offset(priv, priv->bbvga[0]);
        }
 
        if (changed & BSS_CHANGED_TXPOWER)