drm/msm: Remove unnecessary pm_runtime_get/put
authorAkhil P Oommen <quic_akhilpo@quicinc.com>
Thu, 18 Aug 2022 20:22:09 +0000 (01:52 +0530)
committerRob Clark <robdclark@chromium.org>
Sun, 28 Aug 2022 16:29:27 +0000 (09:29 -0700)
We already enable gpu power from msm_gpu_submit(), so avoid a duplicate
pm_runtime_get/put from msm_job_run().

Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/498390/
Link: https://lore.kernel.org/r/20220819015030.v5.1.Icf1e8f0c9b3e7e9933c3b48c70477d0582f3243f@changeid
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/msm_ringbuffer.c

index 56eecb4a72dc6d3e270316e88b20fcd37932117e..cad4c3525f0be8e7f284bd7012a3b2fade258bc6 100644 (file)
@@ -29,8 +29,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job)
                msm_gem_unlock(obj);
        }
 
-       pm_runtime_get_sync(&gpu->pdev->dev);
-
        /* TODO move submit path over to using a per-ring lock.. */
        mutex_lock(&gpu->lock);
 
@@ -38,8 +36,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job)
 
        mutex_unlock(&gpu->lock);
 
-       pm_runtime_put(&gpu->pdev->dev);
-
        return dma_fence_get(submit->hw_fence);
 }