net: dsa: vsc73xx: use macros for rgmii recognition
authorPawel Dembicki <paweldembicki@gmail.com>
Wed, 17 Apr 2024 20:50:46 +0000 (22:50 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 22 Apr 2024 21:21:32 +0000 (14:21 -0700)
It's preparation for future use. At this moment, the RGMII port is used
only for a connection to the MAC interface, but in the future, someone
could connect a PHY to it. Using the "phy_interface_mode_is_rgmii" macro
allows for the proper recognition of all RGMII modes.

Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/20240417205048.3542839-4-paweldembicki@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/vitesse-vsc73xx-core.c

index ad3634cf907eddb4ff717beeaa85d3aca14ee0d9..af148c58315a657152257bf037b7ac91ec4e203d 100644 (file)
@@ -810,7 +810,7 @@ static void vsc73xx_mac_link_up(struct phylink_config *config,
        else
                val = VSC73XX_MAC_CFG_TX_IPG_100_10M;
 
-       if (interface == PHY_INTERFACE_MODE_RGMII)
+       if (phy_interface_mode_is_rgmii(interface))
                val |= VSC73XX_MAC_CFG_CLK_SEL_1000M;
        else
                val |= VSC73XX_MAC_CFG_CLK_SEL_EXT;