projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0566fa7
)
powerpc/kprobes: Warn if instruction patching failed
author
Naveen N. Rao
<naveen.n.rao@linux.vnet.ibm.com>
Wed, 19 May 2021 10:47:21 +0000
(16:17 +0530)
committer
Michael Ellerman
<mpe@ellerman.id.au>
Fri, 25 Jun 2021 04:47:18 +0000
(14:47 +1000)
When arming and disarming probes, we currently assume that instruction
patching can never fail, and don't have a mechanism to surface errors.
Add a warning in case instruction patching ever fails.
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link:
https://lore.kernel.org/r/18d7b1309f938c08ce07738100932b551bdd3a52.1621416666.git.naveen.n.rao@linux.vnet.ibm.com
arch/powerpc/kernel/kprobes.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/kernel/kprobes.c
b/arch/powerpc/kernel/kprobes.c
index 2303511c77457825223d4e8c8091bbc29a9c08ac..eeb6beade975644c8961ce5f0281cbf94abc011f 100644
(file)
--- a/
arch/powerpc/kernel/kprobes.c
+++ b/
arch/powerpc/kernel/kprobes.c
@@
-165,13
+165,13
@@
NOKPROBE_SYMBOL(arch_prepare_kprobe);
void arch_arm_kprobe(struct kprobe *p)
{
-
patch_instruction(p->addr, ppc_inst(BREAKPOINT_INSTRUCTION
));
+
WARN_ON_ONCE(patch_instruction(p->addr, ppc_inst(BREAKPOINT_INSTRUCTION)
));
}
NOKPROBE_SYMBOL(arch_arm_kprobe);
void arch_disarm_kprobe(struct kprobe *p)
{
-
patch_instruction(p->addr, ppc_inst(p->opcode
));
+
WARN_ON_ONCE(patch_instruction(p->addr, ppc_inst(p->opcode)
));
}
NOKPROBE_SYMBOL(arch_disarm_kprobe);