RDMA/nldev: Return context information
authorNeta Ostrovsky <netao@nvidia.com>
Sun, 18 Apr 2021 13:41:23 +0000 (16:41 +0300)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 22 Apr 2021 13:30:27 +0000 (10:30 -0300)
Extend the RDMA nldev return a context information, like ctx number and
process ID that created that context. This functionality is helpful to
find orphan contexts that are not closed for some reason.

Sample output:

$ rdma res show ctx
dev ibp8s0f0 ctxn 0 pid 980 comm ibv_rc_pingpong
dev ibp8s0f0 ctxn 1 pid 981 comm ibv_rc_pingpong
dev ibp8s0f0 ctxn 2 pid 992 comm ibv_rc_pingpong
dev ibp8s0f1 ctxn 0 pid 984 comm ibv_rc_pingpong
dev ibp8s0f1 ctxn 1 pid 987 comm ibv_rc_pingpong

$ rdma res show ctx dev ibp8s0f1
dev ibp8s0f1 ctxn 0 pid 984 comm ibv_rc_pingpong
dev ibp8s0f1 ctxn 1 pid 987 comm ibv_rc_pingpong

Link: https://lore.kernel.org/r/5c956acfeac4e9d532988575f3da7d64cb449374.1618753110.git.leonro@nvidia.com
Signed-off-by: Neta Ostrovsky <netao@nvidia.com>
Reviewed-by: Mark Zhang <markzhang@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/core/nldev.c
include/uapi/rdma/rdma_netlink.h

index b8dc002a24789f73853a15d5609d85b69e7f6da4..d33d212298f6692a53b4f1864a0d47af029dd697 100644 (file)
@@ -92,7 +92,9 @@ static const struct nla_policy nldev_policy[RDMA_NLDEV_ATTR_MAX] = {
        [RDMA_NLDEV_ATTR_RES_CQE]               = { .type = NLA_U32 },
        [RDMA_NLDEV_ATTR_RES_CQN]               = { .type = NLA_U32 },
        [RDMA_NLDEV_ATTR_RES_CQ_ENTRY]          = { .type = NLA_NESTED },
+       [RDMA_NLDEV_ATTR_RES_CTX]               = { .type = NLA_NESTED },
        [RDMA_NLDEV_ATTR_RES_CTXN]              = { .type = NLA_U32 },
+       [RDMA_NLDEV_ATTR_RES_CTX_ENTRY]         = { .type = NLA_NESTED },
        [RDMA_NLDEV_ATTR_RES_DST_ADDR]          = {
                        .len = sizeof(struct __kernel_sockaddr_storage) },
        [RDMA_NLDEV_ATTR_RES_IOVA]              = { .type = NLA_U64 },
@@ -703,6 +705,20 @@ static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin,
 err:   return -EMSGSIZE;
 }
 
+static int fill_res_ctx_entry(struct sk_buff *msg, bool has_cap_net_admin,
+                             struct rdma_restrack_entry *res, uint32_t port)
+{
+       struct ib_ucontext *ctx = container_of(res, struct ib_ucontext, res);
+
+       if (rdma_is_kernel_res(res))
+               return 0;
+
+       if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_CTXN, ctx->res.id))
+               return -EMSGSIZE;
+
+       return fill_res_name_pid(msg, res);
+}
+
 static int fill_stat_counter_mode(struct sk_buff *msg,
                                  struct rdma_counter *counter)
 {
@@ -1236,6 +1252,12 @@ static const struct nldev_fill_res_entry fill_entries[RDMA_RESTRACK_MAX] = {
                .entry = RDMA_NLDEV_ATTR_STAT_COUNTER_ENTRY,
                .id = RDMA_NLDEV_ATTR_STAT_COUNTER_ID,
        },
+       [RDMA_RESTRACK_CTX] = {
+               .nldev_attr = RDMA_NLDEV_ATTR_RES_CTX,
+               .flags = NLDEV_PER_DEV,
+               .entry = RDMA_NLDEV_ATTR_RES_CTX_ENTRY,
+               .id = RDMA_NLDEV_ATTR_RES_CTXN,
+       },
 };
 
 static int res_get_common_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
@@ -1476,6 +1498,7 @@ RES_GET_FUNCS(pd, RDMA_RESTRACK_PD);
 RES_GET_FUNCS(mr, RDMA_RESTRACK_MR);
 RES_GET_FUNCS(mr_raw, RDMA_RESTRACK_MR);
 RES_GET_FUNCS(counter, RDMA_RESTRACK_COUNTER);
+RES_GET_FUNCS(ctx, RDMA_RESTRACK_CTX);
 
 static LIST_HEAD(link_ops);
 static DECLARE_RWSEM(link_ops_rwsem);
@@ -2139,6 +2162,10 @@ static const struct rdma_nl_cbs nldev_cb_table[RDMA_NLDEV_NUM_OPS] = {
                .doit = nldev_res_get_pd_doit,
                .dump = nldev_res_get_pd_dumpit,
        },
+       [RDMA_NLDEV_CMD_RES_CTX_GET] = {
+               .doit = nldev_res_get_ctx_doit,
+               .dump = nldev_res_get_ctx_dumpit,
+       },
        [RDMA_NLDEV_CMD_SYS_GET] = {
                .doit = nldev_sys_get_doit,
        },
index d2f5b839624320ffa1ce1cded227729cd4a57c49..9ec4d4e241fa3df68561c6478005e96e25faeb5f 100644 (file)
@@ -293,6 +293,8 @@ enum rdma_nldev_command {
 
        RDMA_NLDEV_CMD_RES_MR_GET_RAW,
 
+       RDMA_NLDEV_CMD_RES_CTX_GET, /* can dump */
+
        RDMA_NLDEV_NUM_OPS
 };
 
@@ -533,6 +535,9 @@ enum rdma_nldev_attr {
 
        RDMA_NLDEV_ATTR_RES_RAW,        /* binary */
 
+       RDMA_NLDEV_ATTR_RES_CTX,                /* nested table */
+       RDMA_NLDEV_ATTR_RES_CTX_ENTRY,          /* nested table */
+
        /*
         * Always the end
         */