staging: wfx: drop useless function

Since the code for multicast filtering has been dropped, the function
hif_set_data_filtering() is only called to disable multicast filtering.
In fact, the multicast filtering is already disabled by default. So,
this function is useless and can be dropped.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200907101521.66082-8-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/wfx/hif_api_mib.h b/drivers/staging/wfx/hif_api_mib.h
index d0e0a9e29afa6e0f814e11cb3873b5892de7b5af..73873d29456dd32bc26eaa3d0f5ea0c5f772a3cb 100644 (file)
--- a/drivers/staging/wfx/hif_api_mib.h
+++ b/drivers/staging/wfx/hif_api_mib.h
@@ -82,14 +82,6 @@ struct hif_mib_gl_set_multi_msg {
        u8     reserved2[3];
 } __packed;
 
-struct hif_mib_set_data_filtering {
-       u8     invert_matching:1;
-       u8     reserved1:7;
-       u8     enable:1;
-       u8     reserved2:7;
-       u8     reserved3[2];
-} __packed;
-
 enum hif_arp_ns_frame_treatment {
        HIF_ARP_NS_FILTERING_DISABLE = 0x0,
        HIF_ARP_NS_FILTERING_ENABLE  = 0x1,

diff --git a/drivers/staging/wfx/hif_tx_mib.c b/drivers/staging/wfx/hif_tx_mib.c
index 7f24e9f77c2279a1dd43b924d090bf564694b8b8..2eb2a20890c742c2c9cbd56c1401a58250dbddb8 100644 (file)
--- a/drivers/staging/wfx/hif_tx_mib.c
+++ b/drivers/staging/wfx/hif_tx_mib.c
@@ -228,17 +228,6 @@ int hif_set_tx_rate_retry_policy(struct wfx_vif *wvif,
        return ret;
 }
 
-int hif_set_data_filtering(struct wfx_vif *wvif, bool enable, bool invert)
-{
-       struct hif_mib_set_data_filtering val = {
-               .enable = enable,
-               .invert_matching = invert,
-       };
-
-       return hif_write_mib(wvif->wdev, wvif->id,
-                            HIF_MIB_ID_SET_DATA_FILTERING, &val, sizeof(val));
-}
-
 int hif_keep_alive_period(struct wfx_vif *wvif, int period)
 {
        struct hif_mib_keep_alive_period arg = {

diff --git a/drivers/staging/wfx/hif_tx_mib.h b/drivers/staging/wfx/hif_tx_mib.h
index d4cac63164baa7d3fd84e7684ea012064c6b7f12..6c25015173cd3b72601dc457d1e3ce0a0e417b15 100644 (file)
--- a/drivers/staging/wfx/hif_tx_mib.h
+++ b/drivers/staging/wfx/hif_tx_mib.h
@@ -37,7 +37,6 @@ int hif_set_association_mode(struct wfx_vif *wvif, int ampdu_density,
                             bool greenfield, bool short_preamble);
 int hif_set_tx_rate_retry_policy(struct wfx_vif *wvif,
                                 int policy_index, u8 *rates);
-int hif_set_data_filtering(struct wfx_vif *wvif, bool enable, bool invert);
 int hif_keep_alive_period(struct wfx_vif *wvif, int period);
 int hif_set_arp_ipv4_filter(struct wfx_vif *wvif, int idx, __be32 *addr);
 int hif_use_multi_tx_conf(struct wfx_dev *wdev, bool enable);

diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 8700d2fc6a7739899822a0300daec5327b1a8b47..0d27ca27e48c8fe5e6e1c130a117a50668ea3337 100644 (file)
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -120,8 +120,6 @@ void wfx_configure_filter(struct ieee80211_hw *hw, unsigned int changed_flags,
                        filter_beacon = true;
                wfx_filter_beacon(wvif, filter_beacon);
 
-               hif_set_data_filtering(wvif, false, true);
-
                if (*total_flags & FIF_OTHER_BSS)
                        filter_bssid = false;
                else