staging: unisys: use eth_hw_addr_set()
authorJakub Kicinski <kuba@kernel.org>
Tue, 19 Oct 2021 17:12:41 +0000 (10:12 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Oct 2021 17:33:58 +0000 (19:33 +0200)
Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20211019171243.1412240-7-kuba@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c

index a3bc568c660d4d6b69ff9f5ce24af8361c863b5c..62cd9b783732cefab1811584f8f006610ee61b27 100644 (file)
@@ -1782,6 +1782,7 @@ static int visornic_probe(struct visor_device *dev)
        struct net_device *netdev = NULL;
        int err;
        int channel_offset = 0;
+       u8 addr[ETH_ALEN];
        u64 features;
 
        netdev = alloc_etherdev(sizeof(struct visornic_devdata));
@@ -1798,14 +1799,14 @@ static int visornic_probe(struct visor_device *dev)
        /* Get MAC address from channel and read it into the device. */
        netdev->addr_len = ETH_ALEN;
        channel_offset = offsetof(struct visor_io_channel, vnic.macaddr);
-       err = visorbus_read_channel(dev, channel_offset, netdev->dev_addr,
-                                   ETH_ALEN);
+       err = visorbus_read_channel(dev, channel_offset, addr, ETH_ALEN);
        if (err < 0) {
                dev_err(&dev->device,
                        "%s failed to get mac addr from chan (%d)\n",
                        __func__, err);
                goto cleanup_netdev;
        }
+       eth_hw_addr_set(netdev, addr);
 
        devdata = devdata_initialize(netdev_priv(netdev), dev);
        if (!devdata) {