loongarch/cpu: Make sure play_dead() doesn't return
authorJosh Poimboeuf <jpoimboe@kernel.org>
Tue, 14 Feb 2023 07:05:41 +0000 (23:05 -0800)
committerJosh Poimboeuf <jpoimboe@kernel.org>
Mon, 6 Mar 2023 23:34:06 +0000 (15:34 -0800)
play_dead() doesn't return.  Make that more explicit with a BUG().

BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.

Link: https://lore.kernel.org/r/21245d687ffeda34dbcf04961a2df3724f04f7c8.1676358308.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
arch/loongarch/kernel/smp.c

index 8c6e227cb29df47b8d143dbf9766229a785813b9..51f328169a7b7115d1f0bc7a173423147c6f780e 100644 (file)
@@ -336,7 +336,7 @@ void play_dead(void)
        iocsr_write32(0xffffffff, LOONGARCH_IOCSR_IPI_CLEAR);
 
        init_fn();
-       unreachable();
+       BUG();
 }
 
 #endif