scsi: ufs: core: Changing the status to check inflight
authorSEO HOYOUNG <hy50.seo@samsung.com>
Thu, 11 Apr 2024 07:14:44 +0000 (16:14 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 12 Apr 2024 01:54:22 +0000 (21:54 -0400)
ufshcd_cmd_inflight() is used to check whether or not a command is in
progress.  Make it skip commands that have already completed by changing
the !blk_mq_request_started(rq) check into blk_mq_rq_state(rq) !=
MQ_RQ_IN_FLIGHT.  We cannot rely on lrbp->cmd since lrbp->cmd is not
cleared when a command completes.

Link: https://lore.kernel.org/linux-scsi/20230517223157.1068210-3-bvanassche@acm.org/
Signed-off-by: SEO HOYOUNG <hy50.seo@samsung.com>
Link: https://lore.kernel.org/r/20240411071444.51873-1-hy50.seo@samsung.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index c72ef87ea867814d01889055426a3a0e16805f9b..392fc1098988f7f0b12952f3057d16e96e831092 100644 (file)
@@ -3041,16 +3041,7 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba,
  */
 bool ufshcd_cmd_inflight(struct scsi_cmnd *cmd)
 {
-       struct request *rq;
-
-       if (!cmd)
-               return false;
-
-       rq = scsi_cmd_to_rq(cmd);
-       if (!blk_mq_request_started(rq))
-               return false;
-
-       return true;
+       return cmd && blk_mq_rq_state(scsi_cmd_to_rq(cmd)) == MQ_RQ_IN_FLIGHT;
 }
 
 /*