of: unittest: Drop if blocks with always false condition

unittest_gpio_remove() is only called after unittest_gpio_probe() completed
successfully. In this case driver data was set to a non-NULL value and so
platform_get_drvdata() never returns NULL.

Also note that the compiler might optimize away this check anyhow as
devptr was already dereferenced for the dev_dbg call above.

Drop this if block.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230319100620.295849-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Rob Herring <robh@kernel.org>

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 2504092e83026507908e40f34619abf18b07464f..0b0b966133b7540757c71dbcc1138286361026d1 100644 (file)
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1633,9 +1633,6 @@ static int unittest_gpio_remove(struct platform_device *pdev)
 
        dev_dbg(dev, "%s for node @%pfw\n", __func__, devptr->chip.fwnode);
 
-       if (!devptr)
-               return -EINVAL;
-
        if (devptr->chip.base != -1)
                gpiochip_remove(&devptr->chip);