projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a725272
)
spi: dw: Fix Designware SPI loopback
author
Thor Thayer
<thor.thayer@linux.intel.com>
Tue, 5 Nov 2019 20:22:10 +0000
(14:22 -0600)
committer
Mark Brown
<broonie@kernel.org>
Tue, 5 Nov 2019 23:48:19 +0000
(23:48 +0000)
The SPI_LOOP is set in spi->mode but not propagated to the register.
A previous patch removed the bit during a cleanup.
Fixes: e1bc204894ea ("spi: dw: fix potential variable assignment error")
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
Link:
https://lore.kernel.org/r/1572985330-5525-1-git-send-email-thor.thayer@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-dw.c
b/drivers/spi/spi-dw.c
index 9a49e073e8b7347f101a6d2e97f96ebe5108158b..076652d3d051ee8fc19ea701fd50c607db4f30d1 100644
(file)
--- a/
drivers/spi/spi-dw.c
+++ b/
drivers/spi/spi-dw.c
@@
-308,7
+308,8
@@
static int dw_spi_transfer_one(struct spi_controller *master,
cr0 = (transfer->bits_per_word - 1)
| (chip->type << SPI_FRF_OFFSET)
| ((((spi->mode & SPI_CPOL) ? 1 : 0) << SPI_SCOL_OFFSET) |
- (((spi->mode & SPI_CPHA) ? 1 : 0) << SPI_SCPH_OFFSET))
+ (((spi->mode & SPI_CPHA) ? 1 : 0) << SPI_SCPH_OFFSET) |
+ (((spi->mode & SPI_LOOP) ? 1 : 0) << SPI_SRL_OFFSET))
| (chip->tmode << SPI_TMOD_OFFSET);
/*