gpioset: fix memory leak in interactive mode

Even when readline() returns an empty buffer, we still need to free() it to
avoid leaking memory.

Signed-off-by: Esben Haabendal <esben@geanix.com>
[Kent: suggested a shorter version]
Co-developed-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/tools/gpioset.c b/tools/gpioset.c
index 698dba383ed5f3e94e93eafc3020614153b5aedb..374fe728abc91e60cec169abafbea6b6f8faf3e1 100644 (file)
--- a/tools/gpioset.c
+++ b/tools/gpioset.c
@@ -768,8 +768,10 @@ static void interact(struct gpiod_line_request **requests,
                fflush(stdout);
 
                line = readline(PROMPT);
-               if (!line || line[0] == '\0')
+               if (!line || line[0] == '\0') {
+                       free(line);
                        continue;
+               }
 
                for (i = strlen(line) - 1; (i > 0) && isspace(line[i]); i--)
                        line[i] = '\0';