tests/qapi-schema: Drop TODO comment on simple unions
authorMarkus Armbruster <armbru@redhat.com>
Tue, 23 Mar 2021 09:40:02 +0000 (10:40 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 23 Mar 2021 20:39:18 +0000 (21:39 +0100)
Simple unions don't need more features, they need to die.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210323094025.3569441-6-armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
tests/qapi-schema/flat-union-no-base.err
tests/qapi-schema/flat-union-no-base.json

index 9bd595bcfb2ffcd7c502ca614de90e743ff0072d..5167565b000f7a87f919026578036425657fa708 100644 (file)
@@ -1,2 +1,2 @@
 flat-union-no-base.json: In union 'TestUnion':
-flat-union-no-base.json:9: 'discriminator' requires 'base'
+flat-union-no-base.json:8: 'discriminator' requires 'base'
index ffc4c6f0e6445552c2fc60dd7ddcf9b94234e4aa..327877b563b9cc854e4f59609998501b1265c8f1 100644 (file)
@@ -1,5 +1,4 @@
 # flat unions require a base
-# TODO: simple unions should be able to use an enum discriminator
 { 'struct': 'TestTypeA',
   'data': { 'string': 'str' } }
 { 'struct': 'TestTypeB',