pwm: dwc: drop redundant error check
authorRaag Jadav <raag.jadav@intel.com>
Mon, 19 Feb 2024 03:38:33 +0000 (09:08 +0530)
committerUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 26 Feb 2024 10:14:46 +0000 (11:14 +0100)
pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
check for failure if the latter is already successful.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20240219033835.11369-3-raag.jadav@intel.com
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/pwm/pwm-dwc.c

index c0e586688e57fe761a56a1eeb4193ccdee7d3846..7dbb72c80ef597e75398cb7a350940b1d8e7adce 100644 (file)
@@ -51,11 +51,8 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
                return ret;
        }
 
+       /* No need to check for failure, pcim_iomap_regions() does it for us. */
        dwc->base = pcim_iomap_table(pci)[0];
-       if (!dwc->base) {
-               dev_err(dev, "Base address missing\n");
-               return -ENOMEM;
-       }
 
        ret = devm_pwmchip_add(dev, chip);
        if (ret)