media: imx335: Set reserved register to default value
authorUmang Jain <umang.jain@ideasonboard.com>
Tue, 20 Feb 2024 09:28:17 +0000 (14:58 +0530)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 23 Feb 2024 13:33:32 +0000 (14:33 +0100)
0x3a00 is a reserved register as per the datasheet. The driver
currently sets to it 0x01 while the datasheet claims 0x00 to be
the default value.

On one of the setup based on i.MX8MP platform with IMX335, this register
write broke the CSI-2 configuration. Setting 0x3a00 to its default
value (i.e. 0x00) fixed the issue. It is not clear from the datasheet
what this register write is responsible for but setting it to its default
value seems the right thing to do, provided it has been found
responsible to break CSI-2 configuration on one of the platform.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reported-by: Matthias Fend <matthias.fend@emfend.at>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/imx335.c

index 7a37eb327ff40bf7bf701ef5995222c5b372221c..3d3848a58fa730e239f4fd3698b3678582dbd03a 100644 (file)
@@ -249,7 +249,7 @@ static const struct imx335_reg mode_2592x1940_regs[] = {
        {0x3794, 0x7a},
        {0x3796, 0xa1},
        {0x37b0, 0x36},
-       {0x3a00, 0x01},
+       {0x3a00, 0x00},
 };
 
 static const struct imx335_reg raw10_framefmt_regs[] = {