x86: do not re-randomize RNG seed on snapshot load
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 25 Oct 2022 00:43:19 +0000 (02:43 +0200)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 27 Oct 2022 10:34:31 +0000 (11:34 +0100)
Snapshot loading is supposed to be deterministic, so we shouldn't
re-randomize the various seeds used.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Message-id: 20221025004327.568476-4-Jason@zx2c4.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/i386/x86.c

index 1148f70c03d7525b16b27167ca2f877f2a725a80..bd50a064a36d98203ff8a8046710b881614136c4 100644 (file)
@@ -1111,7 +1111,7 @@ void x86_load_linux(X86MachineState *x86ms,
         setup_data->type = cpu_to_le32(SETUP_RNG_SEED);
         setup_data->len = cpu_to_le32(RNG_SEED_LENGTH);
         qemu_guest_getrandom_nofail(setup_data->data, RNG_SEED_LENGTH);
-        qemu_register_reset(reset_rng_seed, setup_data);
+        qemu_register_reset_nosnapshotload(reset_rng_seed, setup_data);
         fw_cfg_add_bytes_callback(fw_cfg, FW_CFG_KERNEL_DATA, reset_rng_seed, NULL,
                                   setup_data, kernel, kernel_size, true);
     } else {