USB: gadget: s3c2410_udc: remove dentry storage for debugfs file

There is no need to store the dentry pointer for a debugfs file that we
only use to remove it when the device goes away.  debugfs can do the
lookup for us instead, saving us some trouble, and making things smaller
overall.

Cc: Felipe Balbi <balbi@kernel.org>
Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20210518162105.3698090-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
index 902e9c3e940ad6480c032a73c465886014c6969e..179777cb699fb9c9b51a562fe773bbf3cd0e0d0c 100644 (file)
--- a/drivers/usb/gadget/udc/s3c2410_udc.c
+++ b/drivers/usb/gadget/udc/s3c2410_udc.c
@@ -1843,9 +1843,8 @@ static int s3c2410_udc_probe(struct platform_device *pdev)
        if (retval)
                goto err_add_udc;
 
-       udc->regs_info = debugfs_create_file("registers", S_IRUGO,
-                                            s3c2410_udc_debugfs_root, udc,
-                                            &s3c2410_udc_debugfs_fops);
+       debugfs_create_file("registers", S_IRUGO, s3c2410_udc_debugfs_root, udc,
+                           &s3c2410_udc_debugfs_fops);
 
        dev_dbg(dev, "probe ok\n");
 
@@ -1889,7 +1888,7 @@ static int s3c2410_udc_remove(struct platform_device *pdev)
                return -EBUSY;
 
        usb_del_gadget_udc(&udc->gadget);
-       debugfs_remove(udc->regs_info);
+       debugfs_remove(debugfs_lookup("registers", s3c2410_udc_debugfs_root));
 
        if (udc_info && !udc_info->udc_command &&
                gpio_is_valid(udc_info->pullup_pin))

diff --git a/drivers/usb/gadget/udc/s3c2410_udc.h b/drivers/usb/gadget/udc/s3c2410_udc.h
index 68bdf3e5aac2b6b2fd8f5f75000e2f51a9b36533..135a5bff3c743f5c1b3a5e157fe2bf64fe9996ca 100644 (file)
--- a/drivers/usb/gadget/udc/s3c2410_udc.h
+++ b/drivers/usb/gadget/udc/s3c2410_udc.h
@@ -89,7 +89,6 @@ struct s3c2410_udc {
        unsigned                        req_config : 1;
        unsigned                        req_pending : 1;
        u8                              vbus;
-       struct dentry                   *regs_info;
        int                             irq;
 };
 #define to_s3c2410(g)  (container_of((g), struct s3c2410_udc, gadget))