qapi/parser: Add FIXME for consolidating JSON-related types
authorJohn Snow <jsnow@redhat.com>
Thu, 30 Sep 2021 20:57:13 +0000 (16:57 -0400)
committerMarkus Armbruster <armbru@redhat.com>
Sat, 2 Oct 2021 05:33:42 +0000 (07:33 +0200)
The fix for this comment is forthcoming in a future commit, but this
will keep me honest. The linting configuration in ./python/setup.cfg
prohibits 'FIXME' comments. A goal of this long-running series is to
move ./scripts/qapi to ./python/qemu/qapi so that the QAPI generator is
regularly type-checked by GitLab CI.

This comment is a time-bomb to force me to address this issue prior to
that step.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210930205716.1148693-11-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
scripts/qapi/parser.py

index 73c1c4ef599951f4dcf628647634aa00f986df10..0265b47b955a3d22160b0217bd0197cb310c2454 100644 (file)
@@ -43,6 +43,10 @@ TopLevelExpr = Dict[str, object]
 # Return value alias for get_expr().
 _ExprValue = Union[List[object], Dict[str, object], str, bool]
 
+# FIXME: Consolidate and centralize definitions for TopLevelExpr,
+# _ExprValue, _JSONValue, and _JSONObject; currently scattered across
+# several modules.
+
 
 class QAPIParseError(QAPISourceError):
     """Error class for all QAPI schema parsing errors."""