wifi: mwifiex: fix loop iterator in mwifiex_update_ampdu_txwinsize()
authorDan Carpenter <error27@gmail.com>
Mon, 6 Feb 2023 14:41:33 +0000 (17:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:39:17 +0000 (09:39 +0100)
[ Upstream commit 3cfb7df24cee0f5fdc4cc5d3176cab9aadfcb430 ]

This code re-uses "i" to be the iterator for both the inside and outside
loops.  It means the outside loop will exit earlier than intended.

Fixes: d219b7eb3792 ("mwifiex: handle BT coex event to adjust Rx BA window size")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/Y+ERnaDaZD7RtLvX@kili
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/mwifiex/11n.c

index cf08a4af84d6d7fa82b1ba925eb6c34026095220..b99381ebb82a14322b3508cd75285602cf55e965 100644 (file)
@@ -890,7 +890,7 @@ mwifiex_send_delba_txbastream_tbl(struct mwifiex_private *priv, u8 tid)
  */
 void mwifiex_update_ampdu_txwinsize(struct mwifiex_adapter *adapter)
 {
-       u8 i;
+       u8 i, j;
        u32 tx_win_size;
        struct mwifiex_private *priv;
 
@@ -921,8 +921,8 @@ void mwifiex_update_ampdu_txwinsize(struct mwifiex_adapter *adapter)
                if (tx_win_size != priv->add_ba_param.tx_win_size) {
                        if (!priv->media_connected)
                                continue;
-                       for (i = 0; i < MAX_NUM_TID; i++)
-                               mwifiex_send_delba_txbastream_tbl(priv, i);
+                       for (j = 0; j < MAX_NUM_TID; j++)
+                               mwifiex_send_delba_txbastream_tbl(priv, j);
                }
        }
 }