RDMA/rtrs-clt: Remove duplicated switch-case handling for CM error events
authorGioh Kim <gi-oh.kim@cloud.ionos.com>
Fri, 23 Oct 2020 07:43:49 +0000 (09:43 +0200)
committerJason Gunthorpe <jgg@nvidia.com>
Wed, 28 Oct 2020 16:17:40 +0000 (13:17 -0300)
The events returning the same error value are put together.

Link: https://lore.kernel.org/r/20201023074353.21946-9-jinpu.wang@cloud.ionos.com
Signed-off-by: Gioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/ulp/rtrs/rtrs-clt.c

index 4e5da834034a63a7fe8debe2660f060056b07bf2..30eda2f355e1c0fede37e518bcfc8b53c50eb096 100644 (file)
@@ -1843,20 +1843,22 @@ static int rtrs_clt_rdma_cm_handler(struct rdma_cm_id *cm_id,
        case RDMA_CM_EVENT_REJECTED:
                cm_err = rtrs_rdma_conn_rejected(con, ev);
                break;
+       case RDMA_CM_EVENT_DISCONNECTED:
+               /* No message for disconnecting */
+               cm_err = -ECONNRESET;
+               break;
        case RDMA_CM_EVENT_CONNECT_ERROR:
        case RDMA_CM_EVENT_UNREACHABLE:
+       case RDMA_CM_EVENT_ADDR_CHANGE:
+       case RDMA_CM_EVENT_TIMEWAIT_EXIT:
                rtrs_wrn(s, "CM error event %d\n", ev->event);
                cm_err = -ECONNRESET;
                break;
        case RDMA_CM_EVENT_ADDR_ERROR:
        case RDMA_CM_EVENT_ROUTE_ERROR:
+               rtrs_wrn(s, "CM error event %d\n", ev->event);
                cm_err = -EHOSTUNREACH;
                break;
-       case RDMA_CM_EVENT_DISCONNECTED:
-       case RDMA_CM_EVENT_ADDR_CHANGE:
-       case RDMA_CM_EVENT_TIMEWAIT_EXIT:
-               cm_err = -ECONNRESET;
-               break;
        case RDMA_CM_EVENT_DEVICE_REMOVAL:
                /*
                 * Device removal is a special case.  Queue close and return 0.