net/mlx5: Compare with old_dest param to modify rule destination

The rule destination must be compared with the old_dest passed in.

Signed-off-by: Jianbo Liu <jianbol@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/24adc60d05d7492359ba343c6da1ebbe9fe284f6.1690802064.git.leon@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 830ff8480fe11ac218a18542668201bd1fa668fb..59df6156246e7a358443506e397c630180c73507 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -1066,7 +1066,7 @@ int mlx5_modify_rule_destination(struct mlx5_flow_handle *handle,
        }
 
        for (i = 0; i < handle->num_rules; i++) {
-               if (mlx5_flow_dests_cmp(new_dest, &handle->rule[i]->dest_attr))
+               if (mlx5_flow_dests_cmp(old_dest, &handle->rule[i]->dest_attr))
                        return _mlx5_modify_rule_destination(handle->rule[i],
                                                             new_dest);
        }