iio: adc: ltc2496: Fix alignment for DMA safety
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 May 2022 17:56:01 +0000 (18:56 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 14 Jun 2022 10:53:13 +0000 (11:53 +0100)
____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Update the comment to include 'may'.

Fixes: e4c5c4dfaa88 ("iio: adc: new driver to support Linear technology's ltc2496")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-22-jic23@kernel.org
drivers/iio/adc/ltc2496.c

index 5a55f79f2574905ae63fb8f2bbd51928757a04ee..dfb3bb5997e579f1cf1cf32456444d026820eeaf 100644 (file)
@@ -24,10 +24,10 @@ struct ltc2496_driverdata {
        struct spi_device *spi;
 
        /*
-        * DMA (thus cache coherency maintenance) requires the
+        * DMA (thus cache coherency maintenance) may require the
         * transfer buffers to live in their own cache lines.
         */
-       unsigned char rxbuf[3] ____cacheline_aligned;
+       unsigned char rxbuf[3] __aligned(IIO_DMA_MINALIGN);
        unsigned char txbuf[3];
 };