cpufreq: schedutil: Merge initialization code of sg_cpu in single loop
authorLiao Chang <liaochang1@huawei.com>
Fri, 8 Sep 2023 03:16:04 +0000 (03:16 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 6 Oct 2023 19:51:40 +0000 (21:51 +0200)
The initialization code of the per-cpu sg_cpu struct is currently split
into two for-loop blocks. This can be simplified by merging the two
blocks into a single loop. This will make the code more maintainable.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
kernel/sched/cpufreq_schedutil.c

index 4492608b7d7f1c715f46ae462fd760e074066ced..f3a95def49ccab272c49bc8566398c65cf8ad344 100644 (file)
@@ -767,14 +767,6 @@ static int sugov_start(struct cpufreq_policy *policy)
 
        sg_policy->need_freq_update = cpufreq_driver_test_flags(CPUFREQ_NEED_UPDATE_LIMITS);
 
-       for_each_cpu(cpu, policy->cpus) {
-               struct sugov_cpu *sg_cpu = &per_cpu(sugov_cpu, cpu);
-
-               memset(sg_cpu, 0, sizeof(*sg_cpu));
-               sg_cpu->cpu                     = cpu;
-               sg_cpu->sg_policy               = sg_policy;
-       }
-
        if (policy_is_shared(policy))
                uu = sugov_update_shared;
        else if (policy->fast_switch_enabled && cpufreq_driver_has_adjust_perf())
@@ -785,6 +777,9 @@ static int sugov_start(struct cpufreq_policy *policy)
        for_each_cpu(cpu, policy->cpus) {
                struct sugov_cpu *sg_cpu = &per_cpu(sugov_cpu, cpu);
 
+               memset(sg_cpu, 0, sizeof(*sg_cpu));
+               sg_cpu->cpu = cpu;
+               sg_cpu->sg_policy = sg_policy;
                cpufreq_add_update_util_hook(cpu, &sg_cpu->update_util, uu);
        }
        return 0;