drm/sprd: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert the sprd drm drivers from always returning zero in the
remove callback to the void returning variant.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102165640.3307820-33-u.kleine-koenig@pengutronix.de

diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
index 48183bbd0590dd53f711aa690c6b6dd8195f7b75..deb3bb96e2a8a9cf2cd0b6b5cfd5ae218ed4a317 100644 (file)
--- a/drivers/gpu/drm/sprd/sprd_dpu.c
+++ b/drivers/gpu/drm/sprd/sprd_dpu.c
@@ -859,16 +859,14 @@ static int sprd_dpu_probe(struct platform_device *pdev)
        return component_add(&pdev->dev, &dpu_component_ops);
 }
 
-static int sprd_dpu_remove(struct platform_device *pdev)
+static void sprd_dpu_remove(struct platform_device *pdev)
 {
        component_del(&pdev->dev, &dpu_component_ops);
-
-       return 0;
 }
 
 struct platform_driver sprd_dpu_driver = {
        .probe = sprd_dpu_probe,
-       .remove = sprd_dpu_remove,
+       .remove_new = sprd_dpu_remove,
        .driver = {
                .name = "sprd-dpu-drv",
                .of_match_table = dpu_match_table,

diff --git a/drivers/gpu/drm/sprd/sprd_drm.c b/drivers/gpu/drm/sprd/sprd_drm.c
index 0aa39156f2fabc2c387003a5b18708366090a3db..a74cd0caf64503ffcdae5ffb422632ea487cbfa4 100644 (file)
--- a/drivers/gpu/drm/sprd/sprd_drm.c
+++ b/drivers/gpu/drm/sprd/sprd_drm.c
@@ -138,10 +138,9 @@ static int sprd_drm_probe(struct platform_device *pdev)
        return drm_of_component_probe(&pdev->dev, component_compare_of, &drm_component_ops);
 }
 
-static int sprd_drm_remove(struct platform_device *pdev)
+static void sprd_drm_remove(struct platform_device *pdev)
 {
        component_master_del(&pdev->dev, &drm_component_ops);
-       return 0;
 }
 
 static void sprd_drm_shutdown(struct platform_device *pdev)
@@ -164,7 +163,7 @@ MODULE_DEVICE_TABLE(of, drm_match_table);
 
 static struct platform_driver sprd_drm_driver = {
        .probe = sprd_drm_probe,
-       .remove = sprd_drm_remove,
+       .remove_new = sprd_drm_remove,
        .shutdown = sprd_drm_shutdown,
        .driver = {
                .name = "sprd-drm-drv",

diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd_dsi.c
index d7b143a7560157beb391b619b23e0ac7b7bbd46c..0b69c140eab36f897d903bd7615c7e4754396762 100644 (file)
--- a/drivers/gpu/drm/sprd/sprd_dsi.c
+++ b/drivers/gpu/drm/sprd/sprd_dsi.c
@@ -1051,18 +1051,16 @@ static int sprd_dsi_probe(struct platform_device *pdev)
        return mipi_dsi_host_register(&dsi->host);
 }
 
-static int sprd_dsi_remove(struct platform_device *pdev)
+static void sprd_dsi_remove(struct platform_device *pdev)
 {
        struct sprd_dsi *dsi = dev_get_drvdata(&pdev->dev);
 
        mipi_dsi_host_unregister(&dsi->host);
-
-       return 0;
 }
 
 struct platform_driver sprd_dsi_driver = {
        .probe = sprd_dsi_probe,
-       .remove = sprd_dsi_remove,
+       .remove_new = sprd_dsi_remove,
        .driver = {
                .name = "sprd-dsi-drv",
                .of_match_table = dsi_match_table,