nvdimm/btt: add error handling support for add_disk()
authorLuis Chamberlain <mcgrof@kernel.org>
Wed, 3 Nov 2021 23:04:25 +0000 (16:04 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 4 Nov 2021 11:48:49 +0000 (05:48 -0600)
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20211103230437.1639990-3-mcgrof@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvdimm/btt.c

index 5cb6d7ac6e36487b61b368d69bd4dee9b33853a6..38ed53eeea5e683659bd05c0b960ec1bc81e4228 100644 (file)
@@ -1541,7 +1541,9 @@ static int btt_blk_init(struct btt *btt)
        }
 
        set_capacity(btt->btt_disk, btt->nlba * btt->sector_size >> 9);
-       device_add_disk(&btt->nd_btt->dev, btt->btt_disk, NULL);
+       rc = device_add_disk(&btt->nd_btt->dev, btt->btt_disk, NULL);
+       if (rc)
+               goto out_cleanup_disk;
 
        btt->nd_btt->size = btt->nlba * (u64)btt->sector_size;
        nvdimm_check_and_set_ro(btt->btt_disk);