perf test: test_intel_pt.sh: Use a temp directory
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 12 Sep 2022 08:34:03 +0000 (11:34 +0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 4 Oct 2022 11:55:23 +0000 (08:55 -0300)
Create a directory for temporary files so that mktemp needs to be used
only once. It also enables more temp files to be added without having to
add them also to the cleanup.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: https://lore.kernel.org/r/20220912083412.7058-3-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/shell/test_intel_pt.sh

index 17338e6a6f9901678c49288bb1b7702bae3b1134..872ee0d89d38dda398a95f588103ac12b61d5391 100755 (executable)
@@ -11,14 +11,20 @@ skip_cnt=0
 ok_cnt=0
 err_cnt=0
 
-tmpfile=`mktemp`
-perfdatafile=`mktemp`
+temp_dir=$(mktemp -d /tmp/perf-test-intel-pt-sh.XXXXXXXXXX)
+
+tmpfile="${temp_dir}/tmp-perf.data"
+perfdatafile="${temp_dir}/test-perf.data"
 
 cleanup()
 {
        trap - EXIT TERM INT
-       rm -f ${tmpfile}
-       rm -f ${perfdatafile}
+       sane=$(echo "${temp_dir}" | cut -b 1-26)
+       if [ "${sane}" = "/tmp/perf-test-intel-pt-sh" ] ; then
+               echo "--- Cleaning up ---"
+               rm -f "${temp_dir}/"*
+               rmdir "${temp_dir}"
+       fi
 }
 
 trap_cleanup()