nfc: s3fwrn5: Constify s3fwrn5_fw_info when not modified
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Sep 2020 16:12:17 +0000 (18:12 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Sep 2020 22:22:16 +0000 (15:22 -0700)
Two functions accept pointer to struct s3fwrn5_fw_info but do not
modify the contents.  Make them const so the code is a little bit safer.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/nfc/s3fwrn5/firmware.c
drivers/nfc/s3fwrn5/firmware.h

index 69857f0807040cba01f0401f095018c80abccddc..ec930ee2c847e7bff26146e5271ec3cbacf3ebfd 100644 (file)
@@ -348,7 +348,7 @@ static int s3fwrn5_fw_get_base_addr(
 }
 
 static inline bool
-s3fwrn5_fw_is_custom(struct s3fwrn5_fw_cmd_get_bootinfo_rsp *bootinfo)
+s3fwrn5_fw_is_custom(const struct s3fwrn5_fw_cmd_get_bootinfo_rsp *bootinfo)
 {
        return !!bootinfo->hw_version[2];
 }
@@ -399,7 +399,7 @@ err:
        return ret;
 }
 
-bool s3fwrn5_fw_check_version(struct s3fwrn5_fw_info *fw_info, u32 version)
+bool s3fwrn5_fw_check_version(const struct s3fwrn5_fw_info *fw_info, u32 version)
 {
        struct s3fwrn5_fw_version *new = (void *) &fw_info->fw.version;
        struct s3fwrn5_fw_version *old = (void *) &version;
index cf1a83a5a52530e7336a56eae869c69b96fdad28..3c83e6730d30d1df50351ebe3b06810d2b912b5b 100644 (file)
@@ -91,7 +91,7 @@ struct s3fwrn5_fw_info {
 
 void s3fwrn5_fw_init(struct s3fwrn5_fw_info *fw_info, const char *fw_name);
 int s3fwrn5_fw_setup(struct s3fwrn5_fw_info *fw_info);
-bool s3fwrn5_fw_check_version(struct s3fwrn5_fw_info *fw_info, u32 version);
+bool s3fwrn5_fw_check_version(const struct s3fwrn5_fw_info *fw_info, u32 version);
 int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info);
 void s3fwrn5_fw_cleanup(struct s3fwrn5_fw_info *fw_info);