iommu/mediatek: Remove for_each_m4u in tlb_sync_all

The tlb_sync_all is called from these three functions:
a) flush_iotlb_all: it will be called for each a iommu HW.
b) tlb_flush_range_sync: it already has for_each_m4u.
c) in irq: When IOMMU HW translation fault, Only need flush itself.

Thus, No need for_each_m4u in this tlb_sync_all. Remove it.

Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20211208120744.2415-2-dafna.hirschfeld@collabora.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 25b834104790cd97f111ac7f934365aa6695bc62..1356137f91f9d1627507f5584d3e9113323780ff 100644 (file)
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -210,17 +210,15 @@ static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom)
 
 static void mtk_iommu_tlb_flush_all(struct mtk_iommu_data *data)
 {
-       for_each_m4u(data) {
-               if (pm_runtime_get_if_in_use(data->dev) <= 0)
-                       continue;
+       if (pm_runtime_get_if_in_use(data->dev) <= 0)
+               return;
 
-               writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
-                              data->base + data->plat_data->inv_sel_reg);
-               writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
-               wmb(); /* Make sure the tlb flush all done */
+       writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
+                      data->base + data->plat_data->inv_sel_reg);
+       writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
+       wmb(); /* Make sure the tlb flush all done */
 
-               pm_runtime_put(data->dev);
-       }
+       pm_runtime_put(data->dev);
 }
 
 static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,