phy: qcom-qmp: drop superfluous comments

Drop some unnecessary or incorrect comments.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221012081241.18273-3-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index 998c8f80ccd808c3cddaa378d3ae552ebf9d875e..3889dcf73c59979511b439b25f59f7c84eafd40e 100644 (file)
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -1949,7 +1949,6 @@ static int qmp_combo_com_init(struct qmp_phy *qphy)
                return 0;
        }
 
-       /* turn on regulator supplies */
        ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);
        if (ret) {
                dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -2779,7 +2778,6 @@ static int qmp_combo_probe(struct platform_device *pdev)
        qmp->dev = dev;
        dev_set_drvdata(dev, qmp);
 
-       /* Get the specific init parameters of QMP phy */
        combo_cfg = of_device_get_match_data(dev);
        if (!combo_cfg)
                return -EINVAL;
@@ -2787,7 +2785,6 @@ static int qmp_combo_probe(struct platform_device *pdev)
        usb_cfg = combo_cfg->usb_cfg;
        cfg = usb_cfg; /* Setup clks and regulators */
 
-       /* per PHY serdes; usually located at base address */
        usb_serdes = serdes = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(serdes))
                return PTR_ERR(serdes);
@@ -2796,7 +2793,6 @@ static int qmp_combo_probe(struct platform_device *pdev)
        if (IS_ERR(qmp->dp_com))
                return PTR_ERR(qmp->dp_com);
 
-       /* Only two serdes for combo PHY */
        dp_serdes = devm_platform_ioremap_resource(pdev, 2);
        if (IS_ERR(dp_serdes))
                return PTR_ERR(dp_serdes);

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
index 45c0e2958bf631cb98f282eb42a226f84f920f2d..8b74948eb467d50e514b64fd577e5bd59a3a439a 100644 (file)
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
@@ -420,7 +420,6 @@ static int qmp_pcie_msm8996_com_init(struct qmp_phy *qphy)
                return 0;
        }
 
-       /* turn on regulator supplies */
        ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);
        if (ret) {
                dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -845,12 +844,10 @@ static int qmp_pcie_msm8996_probe(struct platform_device *pdev)
        qmp->dev = dev;
        dev_set_drvdata(dev, qmp);
 
-       /* Get the specific init parameters of QMP phy */
        cfg = of_device_get_match_data(dev);
        if (!cfg)
                return -EINVAL;
 
-       /* per PHY serdes; usually located at base address */
        serdes = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(serdes))
                return PTR_ERR(serdes);

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index dc7f8ba413b9d21aee6dd861f23b98d5719f17ec..de04d8dd53504c75d433f32ee46a828bb2fb0ca2 100644 (file)
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -1978,7 +1978,6 @@ static int qmp_pcie_init(struct phy *phy)
        const struct qmp_phy_cfg *cfg = qphy->cfg;
        int ret;
 
-       /* turn on regulator supplies */
        ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);
        if (ret) {
                dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -2425,12 +2424,10 @@ static int qmp_pcie_probe(struct platform_device *pdev)
        qmp->dev = dev;
        dev_set_drvdata(dev, qmp);
 
-       /* Get the specific init parameters of QMP phy */
        cfg = of_device_get_match_data(dev);
        if (!cfg)
                return -EINVAL;
 
-       /* per PHY serdes; usually located at base address */
        serdes = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(serdes))
                return PTR_ERR(serdes);

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index 566365fbfe1aeadf8aa98d748a870d3adb8086b4..ab69f648ee3870148fe88c4aab12a35e2579ff5b 100644 (file)
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -849,7 +849,6 @@ static int qmp_ufs_com_init(struct qmp_phy *qphy)
        void __iomem *pcs = qphy->pcs;
        int ret;
 
-       /* turn on regulator supplies */
        ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);
        if (ret) {
                dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -1194,12 +1193,10 @@ static int qmp_ufs_probe(struct platform_device *pdev)
        qmp->dev = dev;
        dev_set_drvdata(dev, qmp);
 
-       /* Get the specific init parameters of QMP phy */
        cfg = of_device_get_match_data(dev);
        if (!cfg)
                return -EINVAL;
 
-       /* per PHY serdes; usually located at base address */
        serdes = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(serdes))
                return PTR_ERR(serdes);

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index a0b97fd5d0a53fd88412242a1e30d381013d6de0..2c5e4041bcf9dda7ff759d9f6014706b71a6ccbc 100644 (file)
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -2120,7 +2120,6 @@ static int qmp_usb_init(struct phy *phy)
        void __iomem *dp_com = qmp->dp_com;
        int ret;
 
-       /* turn on regulator supplies */
        ret = regulator_bulk_enable(cfg->num_vregs, qmp->vregs);
        if (ret) {
                dev_err(qmp->dev, "failed to enable regulators, err=%d\n", ret);
@@ -2229,7 +2228,6 @@ static int qmp_usb_power_on(struct phy *phy)
                                        cfg->rx_tbl, cfg->rx_tbl_num, 2);
        }
 
-       /* Configure link rate, swing, etc. */
        qmp_usb_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num);
 
        if (cfg->has_pwrdn_delay)
@@ -2719,17 +2717,14 @@ static int qmp_usb_probe(struct platform_device *pdev)
        qmp->dev = dev;
        dev_set_drvdata(dev, qmp);
 
-       /* Get the specific init parameters of QMP phy */
        cfg = of_device_get_match_data(dev);
        if (!cfg)
                return -EINVAL;
 
-       /* per PHY serdes; usually located at base address */
        serdes = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(serdes))
                return PTR_ERR(serdes);
 
-       /* per PHY dp_com; if PHY has dp_com control block */
        if (cfg->has_phy_dp_com_ctrl) {
                qmp->dp_com = devm_platform_ioremap_resource(pdev, 1);
                if (IS_ERR(qmp->dp_com))