tty/vt: consolemap: use ARRAY_SIZE()
authorJiri Slaby <jslaby@suse.cz>
Tue, 7 Jun 2022 10:49:11 +0000 (12:49 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jun 2022 11:37:00 +0000 (13:37 +0200)
The code uses constants as bounds in loops. Use ARRAY_SIZE() with
appropriate parameters instead. This makes the loop bounds obvious.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220607104946.18710-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/consolemap.c

index d815ac98b39e3c9d7a791fc805da4ef55b1247c3..839d75d1a6c060e4f46d41675476bc95545b94de 100644 (file)
@@ -408,7 +408,7 @@ static void con_release_unimap(struct uni_pagedir *p)
                }
                p->uni_pgdir[i] = NULL;
        }
-       for (i = 0; i < 4; i++) {
+       for (i = 0; i < ARRAY_SIZE(p->inverse_translations); i++) {
                kfree(p->inverse_translations[i]);
                p->inverse_translations[i] = NULL;
        }
@@ -798,7 +798,7 @@ u32 conv_8bit_to_uni(unsigned char c)
 int conv_uni_to_8bit(u32 uni)
 {
        int c;
-       for (c = 0; c < 0x100; c++)
+       for (c = 0; c < ARRAY_SIZE(translations[USER_MAP]); c++)
                if (translations[USER_MAP][c] == uni ||
                   (translations[USER_MAP][c] == (c | 0xf000) && uni == c))
                        return c;