drm/sun4i: dw-hdmi: Fix missing put_device() call in sun8i_hdmi_phy_get
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 7 Jan 2022 08:36:32 +0000 (08:36 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Mar 2022 18:12:37 +0000 (19:12 +0100)
[ Upstream commit c71af3dae3e34d2fde0c19623cf7f8483321f0e3 ]

The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path.

Fixes: 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220107083633.20843-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c

index b64d93da651d22d03e74057018cea28d37004a02..5e2b0175df36f67484e46fc725f963079b528498 100644 (file)
@@ -658,8 +658,10 @@ int sun8i_hdmi_phy_get(struct sun8i_dw_hdmi *hdmi, struct device_node *node)
                return -EPROBE_DEFER;
 
        phy = platform_get_drvdata(pdev);
-       if (!phy)
+       if (!phy) {
+               put_device(&pdev->dev);
                return -EPROBE_DEFER;
+       }
 
        hdmi->phy = phy;