net/mlx5: remove fw reporter dump option for non PF

In case function is not a Physical Function it is not allowed to get FW
core dump, so if tried it will fail the fw health reporter dump option.
Instead of failing, remove the option of fw_fatal health reporter dump
for such function.

Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Aya Levin <ayal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index 721e343388dfaa895350831a1d56b79961f15bf4..5c2ac2d9dbd996c856f6ef064e4c13ffea3bfdec 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
@@ -555,12 +555,17 @@ static void mlx5_fw_reporter_err_work(struct work_struct *work)
                                      &fw_reporter_ctx);
 }
 
-static const struct devlink_health_reporter_ops mlx5_fw_reporter_ops = {
+static const struct devlink_health_reporter_ops mlx5_fw_reporter_pf_ops = {
                .name = "fw",
                .diagnose = mlx5_fw_reporter_diagnose,
                .dump = mlx5_fw_reporter_dump,
 };
 
+static const struct devlink_health_reporter_ops mlx5_fw_reporter_ops = {
+               .name = "fw",
+               .diagnose = mlx5_fw_reporter_diagnose,
+};
+
 static int
 mlx5_fw_fatal_reporter_recover(struct devlink_health_reporter *reporter,
                               void *priv_ctx,
@@ -666,10 +671,12 @@ void mlx5_fw_reporters_create(struct mlx5_core_dev *dev)
 {
        const struct devlink_health_reporter_ops *fw_fatal_ops;
        struct mlx5_core_health *health = &dev->priv.health;
+       const struct devlink_health_reporter_ops *fw_ops;
        struct devlink *devlink = priv_to_devlink(dev);
        u64 grace_period;
 
        fw_fatal_ops = &mlx5_fw_fatal_reporter_pf_ops;
+       fw_ops = &mlx5_fw_reporter_pf_ops;
        if (mlx5_core_is_ecpf(dev)) {
                grace_period = MLX5_FW_REPORTER_ECPF_GRACEFUL_PERIOD;
        } else if (mlx5_core_is_pf(dev)) {
@@ -678,11 +685,11 @@ void mlx5_fw_reporters_create(struct mlx5_core_dev *dev)
                /* VF or SF */
                grace_period = MLX5_FW_REPORTER_DEFAULT_GRACEFUL_PERIOD;
                fw_fatal_ops = &mlx5_fw_fatal_reporter_ops;
+               fw_ops = &mlx5_fw_reporter_ops;
        }
 
        health->fw_reporter =
-               devl_health_reporter_create(devlink, &mlx5_fw_reporter_ops,
-                                           0, dev);
+               devl_health_reporter_create(devlink, fw_ops, 0, dev);
        if (IS_ERR(health->fw_reporter))
                mlx5_core_warn(dev, "Failed to create fw reporter, err = %ld\n",
                               PTR_ERR(health->fw_reporter));