drm/xe: don't warn for bogus pagefaults
authorMatthew Auld <matthew.auld@intel.com>
Wed, 9 Aug 2023 08:44:24 +0000 (09:44 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:40:19 +0000 (11:40 -0500)
This appears to be easily user triggerable so warning is perhaps too
much. Rather just make it debug print.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/534
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_gt_pagefault.c
drivers/gpu/drm/xe/xe_guc_submit.c

index d8ff05e25eda531a6000eab8601558d1990f325b..21e0e9c7b6340592900e72b8d714148539084098 100644 (file)
@@ -265,7 +265,7 @@ static int send_pagefault_reply(struct xe_guc *guc,
 
 static void print_pagefault(struct xe_device *xe, struct pagefault *pf)
 {
-       drm_warn(&xe->drm, "\n\tASID: %d\n"
+       drm_dbg(&xe->drm, "\n\tASID: %d\n"
                 "\tVFID: %d\n"
                 "\tPDATA: 0x%04x\n"
                 "\tFaulted Address: 0x%08x%08x\n"
@@ -370,7 +370,7 @@ static void pf_queue_work_func(struct work_struct *w)
        if (unlikely(ret)) {
                print_pagefault(xe, &pf);
                pf.fault_unsuccessful = 1;
-               drm_warn(&xe->drm, "Fault response: Unsuccessful %d\n", ret);
+               drm_dbg(&xe->drm, "Fault response: Unsuccessful %d\n", ret);
        }
 
        reply.dw0 = FIELD_PREP(PFR_VALID, 1) |
index 19df4b67bfbbc2e6699455747aae32bf68847cc7..b89964d6562edc3f337a8348289437f45b9ce65b 100644 (file)
@@ -1641,7 +1641,7 @@ int xe_guc_exec_queue_memory_cat_error_handler(struct xe_guc *guc, u32 *msg,
        if (unlikely(!q))
                return -EPROTO;
 
-       drm_warn(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id);
+       drm_dbg(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id);
        trace_xe_exec_queue_memory_cat_error(q);
 
        /* Treat the same as engine reset */